Skip to content
This repository has been archived by the owner on Jun 16, 2022. It is now read-only.

LL-8735 Discover Navigation #2160

Draft
wants to merge 13 commits into
base: develop
Choose a base branch
from
Draft

Conversation

ofreyssinet-ledger
Copy link
Contributor

@ofreyssinet-ledger ofreyssinet-ledger commented Feb 1, 2022

LL-8735

UI implementations regarding the new discover navigation.

Work interrupted for now as it depends heavily on how the backend is structured (which endpoint(s), format of data in the JSON(s) etc.) and that is now in the hands of the platform & services team.

What is left to implement in the UI are:

  • Discover section on home page
  • Promoted apps section (depends on design)

I can go back to working on the frontend/UI part once the structure of the backend is fully defined.

Depending on the changes that are made in the structure of the backend, some things will have to be adapted such

  • where the metadata comes from: descriptions (localization?), categories, tags etc.
  • how filtering works (how the list of all categories is retrieved and how does the filter apply to a list of apps)

⚠️ Indirect but strong dependency on https://github.com/LedgerHQ/ledger-live-assets/pull/243 for the structure of the new endpoint(s).
⚠️ Dependency on LedgerHQ/ledger-live-common#1612 for changes in the PlatformAppProvider (fetching new endpoint(s)). For now this PR works only with a yalc setup for @ledgerhq/live-common.

Type

Feature

Context

LL-8735

Parts of the app affected / Test plan

@ofreyssinet-ledger ofreyssinet-ledger self-assigned this Feb 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant